RFR: 8265917: Different values computed by C2 and interpreter/C1 for Math.pow(x, 2.0) on x86_32 [v2]
Jie Fu
jiefu at openjdk.java.net
Mon Apr 26 06:06:07 UTC 2021
> Hi all,
>
> C2 may produce different results for Math.pow(x, 2.0) compared with interpreter/C1 on x86_32.
>
> E.g., for Math.pow(1.0 / 2047, 2.0):
>
> interpreter: 2.38651580386563E-7
> C2: 2.3865158038656307E-7
>
>
> The reason is that C2 will replace Math.pow(x, 2.0) with x*x.
> However, there is no such optimization for interpreter/C1 on x86_32.
>
> The fix just disables C2's opt for Math.pow(x, 2.0) on x86_32 since nobody (or very few people) would run x86_32.
> And we don't have a plan to implement such opt on x86_32.
>
> Another reason to fix this bug is that we need this patch to extend C2's opt for Math.pow(x, 0.5) on other platforms.
>
> Thanks.
> Best regards,
> Jie
Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
Optimize pow(x, 2.0) for x86_32
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3677/files
- new: https://git.openjdk.java.net/jdk/pull/3677/files/a7d32c25..dde59758
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3677&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3677&range=00-01
Stats: 37 lines in 3 files changed: 17 ins; 13 del; 7 mod
Patch: https://git.openjdk.java.net/jdk/pull/3677.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3677/head:pull/3677
PR: https://git.openjdk.java.net/jdk/pull/3677
More information about the hotspot-compiler-dev
mailing list