RFR: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions [v2]

Dong Bo dongbo at openjdk.java.net
Mon Apr 26 11:20:35 UTC 2021


On Mon, 26 Apr 2021 10:29:24 GMT, Ningsheng Jian <njian at openjdk.org> wrote:

>> Dong Bo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add assembler tests for smaxp/sminp
>
> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 2408:
> 
>> 2406:   INSN(minv,   0, 0b011011, false); // accepted arrangements: T8B, T16B, T4H, T8H, T2S, T4S
>> 2407:   INSN(smaxp,  0, 0b101001, false); // accepted arrangements: T8B, T16B, T4H, T8H, T2S, T4S
>> 2408:   INSN(sminp,  0, 0b101011, false); // accepted arrangements: T8B, T16B, T4H, T8H, T2S, T4S
> 
> Just one nit: do we need an assembler test case for them?

Sure, added in the updated commit. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3683


More information about the hotspot-compiler-dev mailing list