RFR: 8265711: C1: Canonicalize Class.getModifier intrinsic method [v2]

Yi Yang yyang at openjdk.java.net
Tue Apr 27 09:40:17 UTC 2021


On Mon, 26 Apr 2021 09:57:59 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Yi Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - add missing stuff; change according to review comment
>>  - Merge branch 'master' into canon_opt
>>  - canonicalize well-chosen intrinsic methods
>
> src/hotspot/share/c1/c1_Canonicalizer.cpp line 558:
> 
>> 556:     if (c != NULL && !c->value()->is_null_object()) {
>> 557:       ciType* t = c->value()->java_mirror_type();
>> 558:       if (t->is_klass()) {
> 
> Shouldn't `t->is_primitive_type()` be handled as well?

Done.

Testing:
- hotspot/jtreg/compiler

-------------

PR: https://git.openjdk.java.net/jdk/pull/3616


More information about the hotspot-compiler-dev mailing list