RFR: 8266251: compiler.inlining.InlineAccessors shouldn't do testing in driver VM
Vladimir Kozlov
kvn at openjdk.java.net
Wed Apr 28 22:16:52 UTC 2021
On Wed, 28 Apr 2021 21:03:54 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
> Hi all,
>
> could you please review the patch which removes redundant and "incorrect" testing from `InlineAccessors` test? as `InlineAccessors::doTest` is called by the JVM which runs `Launcher` class, we aren't actually losing any coverage.
>
> from JBS:
>> `compiler.inlining.InlineAccessors` test executes `doTest` method in its `InlineAccessors::main`, but InlineAccessors is run in driver mode (so it's not expected to do actual testing and strictly speaking can be executed in JVM other than JVM under test).
>
> Thanks,
> -- Igor
Good.
-------------
Marked as reviewed by kvn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3774
More information about the hotspot-compiler-dev
mailing list