RFR: 8265244: Remove useless comparation in LibraryCallKit::inline_vector_convert() [v2]

Xiaohong Gong xgong at openjdk.java.net
Thu Apr 29 09:17:53 UTC 2021


On Fri, 16 Apr 2021 02:10:10 GMT, Wang Huang <whuang at openjdk.org> wrote:

>> * aarch64 can only accept `VectorReinterpret` with 64/128 bits.
>> * I will fix this bug by adding a rule for `VectorReinterpret` in `match_rule_supported_vector`
>> * after changing note with @nsjian and @XiaohongGong , I think that two checks in `inline_vector_conver` is useless now. However, these checks impact other cpus, so I need more reviewers.
>
> Wang Huang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8265244
>  - 8265244: assert(false) failed: bad AD file

src/hotspot/cpu/aarch64/aarch64.ad line 2405:

> 2403:     switch (opcode) {
> 2404:     case Op_VectorReinterpret:
> 2405:       if (bit_size != 64 && bit_size != 128) {

bit_size < 64 ?

test/hotspot/jtreg/compiler/vectorapi/TestCast4STo2I.java line 39:

> 37: 
> 38: public class TestCast4STo2I {
> 39:     static final VectorSpecies<Short> SPECIESs = ShortVector.SPECIES_64;

SPECIES_S?

test/hotspot/jtreg/compiler/vectorapi/TestCast4STo2I.java line 40:

> 38: public class TestCast4STo2I {
> 39:     static final VectorSpecies<Short> SPECIESs = ShortVector.SPECIES_64;
> 40:     static final VectorSpecies<Integer> SPECIESi = IntVector.SPECIES_64;

ditto

test/hotspot/jtreg/compiler/vectorapi/TestCast4STo2I.java line 72:

> 70:         for (int i = 0; i < SIZE; i++) {
> 71:             System.out.print(ai[i] + ", ");
> 72:         }

It's better to add the correctness testing as well to make sure the results are right.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3507


More information about the hotspot-compiler-dev mailing list