RFR: 8265956: JVM crashes when matching LShiftVB Node [v2]
Wang Huang
whuang at openjdk.java.net
Thu Apr 29 09:49:51 UTC 2021
On Thu, 29 Apr 2021 09:16:04 GMT, Jie Fu <jiefu at openjdk.org> wrote:
>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add m4 file
>
> test/hotspot/jtreg/compiler/vectorapi/TestVectorShuffleIotaShort.java line 44:
>
>> 42: static short[] as = {87, 65, 78, 71, 72, 69, 82, 69};
>> 43:
>> 44: public static void testShuffleS() {
>
> IMO, this test is not enough since the assembly code is not easy to get reviewed.
>
> So I suggest to improve your test:
> 1) Test as many match-patterns you added as possible
> 2) Verify the results in your tests
>
> Thanks.
Thank you for your review.
1 There is only one match-pattern here .
2 I will add checking code here.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3747
More information about the hotspot-compiler-dev
mailing list