RFR: 8265244: Remove useless comparation in LibraryCallKit::inline_vector_convert() [v2]

Andrew Haley aph at redhat.com
Fri Apr 30 08:04:09 UTC 2021


On 4/30/21 3:26 AM, Wang Huang wrote:
> There is only one question here:
> 
>  the comparation 
> 
> int num_elem_for_cast = MIN2(num_elem_from, Matcher::max_vector_size(elem_bt_to));
> 
> which will be removed here can effect all cpus.

Perhaps so. However, you need to do something with the title because this patch
does not simply remove a useless comparison. You might make life easier for
everyone by splitting this patch into two parts.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the hotspot-compiler-dev mailing list