RFR: 8252237: C2: Call to compute_separating_interferences has wrong argument order

Rahul Raghavan rraghavan at openjdk.java.net
Fri Apr 30 17:28:04 UTC 2021


`https://bugs.openjdk.java.net/browse/JDK-8252237`

<Copying details from Old PR - `https://github.com/openjdk/jdk/pull/1533`>
      (**NOTE: This old PR was approved then.
      But we did not commit the changes then because of last stage of JDK 16 
      and waited for more tests, performance runs. 
      Results of multiple test run, performance benchmarks are available now and confirmed no issues)


[`src/hotspot/share/opto/coalesce.hpp`] -
`112 uint compute_separating_interferences(Node *dst_copy, Node *src_copy, Block *b, uint bindex, RegMask &rm, uint rm_size, uint reg_degree, uint lr1, uint lr2);`


[`src/hotspot/share/opto/coalesce.cpp`] -

..........
538 uint PhaseConservativeCoalesce::compute_separating_interferences(Node *dst_copy, Node *src_copy, Block *b, uint bindex, RegMask &rm, uint reg_degree, uint rm_size, uint lr1, uint lr2 ) {
.................
747 reg_degree = compute_separating_interferences(dst_copy, src_copy, b, bindex, rm, rm_size, reg_degree, lr1, lr2 );



So fixing the argument order - [`/src/hotspot/share/opto/coalesce.cpp`]

-uint PhaseConservativeCoalesce::compute_separating_interferences(Node *dst_copy, Node *src_copy, Block *b, uint bindex, RegMask &rm, uint reg_degree, uint rm_size, uint lr1, uint lr2 ) {
+uint PhaseConservativeCoalesce::compute_separating_interferences(Node *dst_copy, Node *src_copy, Block *b, uint bindex, RegMask &rm, uint rm_size, uint reg_degree, uint lr1, uint lr2 ) {

-------------

Commit messages:
 - 8252237: C2: Call to compute_separating_interferences has wrong argument order

Changes: https://git.openjdk.java.net/jdk/pull/3820/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3820&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252237
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3820.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3820/head:pull/3820

PR: https://git.openjdk.java.net/jdk/pull/3820


More information about the hotspot-compiler-dev mailing list