RFR: 8271461: CompileCommand support for hidden class methods [v3]
Ioi Lam
iklam at openjdk.java.net
Tue Aug 3 01:21:33 UTC 2021
On Tue, 3 Aug 2021 00:19:39 GMT, Jie Fu <jiefu at openjdk.org> wrote:
> > Isn't it simple enough after a copy-and-paste from the PrintCompilation output, to replace '/' with '+'?
>
> Yes, that's simple enough but you still need to replace one char by hand.
> And not all the people know the fact that '/' should be replaced by '+' for hidden class.
> To be honest, I didn't know that rule before I digging into the VM code.
>
> > And isn't it the same amount of work to replace / with * or +* vs /_?
>
> This is not enough because sometime only one specific method is expected to be excluded.
> '*' patterns fail to work for such cases.
>
> > This change also seems to allow /_ not just in the class name, but also in the package name.
>
> Yes, there may be false positive.
> But they are all harmless and won't make anything any worse.
Maybe PrintCompilation should be changed to print `+` instead of `/`?
-------------
PR: https://git.openjdk.java.net/jdk/pull/4926
More information about the hotspot-compiler-dev
mailing list