RFR: 8259948: Aarch64: Add cast nodes for Aarch64 Neon backend
Wang Huang
whuang at openjdk.java.net
Tue Aug 3 13:28:48 UTC 2021
On Wed, 21 Jul 2021 03:35:01 GMT, Ningsheng Jian <njian at openjdk.org> wrote:
> Thanks for the work! Some general comments:
>
> > It may be a solver of JDK-8269866, or part of it.
>
> I would suggest not to have a partial fix of JDK-8269866. I think you can still keep 8259948 as duplicate while targeting this to JDK-8269866 and have a fully proper fix. @theRealELiu may have some thoughts on how to have a clean fix: e.g. there may be some dependency on mid-end part, like JDK-8265244?
>
> @theRealELiu has marked those missing rules opcode (with specific types/sizes) as unsupported in JDK-8268966, but I don't see you have unmarked them in your patch. So your newly added rules are not able to be tested. And there are some test cases included in JDK-8268966, could you please merge your test case into existing tests, if existing tests cannot cover some cases.
>
> P.S. could you please fix the jcheck error?
Thank you for your suggestion. We fix these errors and upload new patch.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4839
More information about the hotspot-compiler-dev
mailing list