RFR: 8271589: fatal error with variable shift count integer rotate operation. [v2]

Sandhya Viswanathan sviswanathan at openjdk.java.net
Tue Aug 3 17:25:33 UTC 2021


On Tue, 3 Aug 2021 17:20:36 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8271589: Removing redundant assert.
>
> src/hotspot/share/opto/vectornode.cpp line 1174:
> 
>> 1172:       }
>> 1173:     }
>> 1174:     shiftRCnt = cnt;
> 
> This seems redundant. shiftRCnt is being overwritten in the very next statement.

Other than this redundant statement, the patch looks good to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4956


More information about the hotspot-compiler-dev mailing list