RFR: 8259948: Aarch64: Add cast nodes for Aarch64 Neon backend [v2]

Wu Yan wuyan at openjdk.java.net
Fri Aug 6 15:41:34 UTC 2021


On Wed, 4 Aug 2021 09:13:08 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix code style
>
> src/hotspot/cpu/aarch64/aarch64_neon_ad.m4 line 200:
> 
>> 198:   %}
>> 199:   ins_pipe(pipe_slow);
>> 200: %}
> 
> I'm sure you can find a more brief way to write these four patterns. Please do.

OK, refactored.

> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 2831:
> 
>> 2829:     f(0b000001, 15, 10), rf(Vn, 5), rf(Vd, 0);
>> 2830:   }
>> 2831: 
> 
> Please add the comment
> 
> // Advanced SIMD scalar copy
> ``` 
> here

ok

-------------

PR: https://git.openjdk.java.net/jdk/pull/4839


More information about the hotspot-compiler-dev mailing list