RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v7]

Valerie Peng valeriep at openjdk.java.net
Fri Aug 6 21:41:38 UTC 2021


On Wed, 4 Aug 2021 02:24:05 GMT, Smita Kamath <svkamath at openjdk.org> wrote:

>> I would like to submit AES-GCM optimization for x86_64 architectures supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES and GHASH operations.
>> Performance gain of ~1.5x - 2x for message sizes 8k and above.
>
> Smita Kamath has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - Merge branch 'aes-gcm' of github.com:smita-kamath/jdk into aes-gcm
>  - Updates, comment and variable cleanup
>  - merge rest
>  - merge
>  - fixes and code comments

src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 1508:

> 1506:             if (len > dst.remaining()) {
> 1507:                 throw new ShortBufferException("Output buffer too small, must" +
> 1508:                     "be at least " + (len - tagLenBytes) + " bytes long");

nit: add a space between "must" and "be".
Instead of '(len -tagLenBytes)' should just be 'len' as its initial value already deducts tagLenBytes (see line 1495).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4019


More information about the hotspot-compiler-dev mailing list