RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj [v2]

Hui Shi hshi at openjdk.java.net
Tue Aug 10 13:31:08 UTC 2021


On Tue, 10 Aug 2021 06:29:07 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Hui Shi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo and comment
>
> src/hotspot/share/opto/macroArrayCopy.cpp line 1101:
> 
>> 1099: 
>> 1100:   // When src is negative and arraycopy is before an infinite loop,_callprojs.fallthrough_ioproj
>> 1101:   // could be NULL. Not clone and update NULL fallthrough_ioproj.
> 
> Maybe replace "Not clone" by "Skip clone".

Thanks! Updated.

> test/hotspot/jtreg/compiler/arraycopy/TestIllegalArrayCopyBeforeInfiniteLoop.java line 28:
> 
>> 26:  * @bug 8272131
>> 27:  * @requires vm.compiler2.enabled
>> 28:  * @summary ArrayCopy with negative index before infinit loop
> 
> Typo `infinit` -> `infinite`

Typo fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5054


More information about the hotspot-compiler-dev mailing list