RFR: 8272315: Improve assert_different_registers [v2]

[Andrew Dinn]

On Thu, 12 Aug 2021 03:51:52 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this improvement to assert_different_register.
>> 
>> It reduces ~250 lines of repetitive code to ~10 lines, and improves the
>> error message on failure by printing a duplicated registers name.
>> 
>> Unfortunately, this isn't enough to eliminate AbstractRegister[Impl].
>> Although it seems to no longer be needed for the Oracle-supported platforms,
>> the linux-arm/ppc64le/s390 platforms all use the value() function provided
>> by AbstractRegisterImpl.
>> 
>> Testing:
>> tier1 on Oracle supported platforms.
>> built linux-arm/ppc64le/s390.
>> 
>> Locally changed a call to have a duplicate register and verified the error
>> message had a useful register name.
>
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
> 
>   nested loop instead of sort

Still good

-------------

Marked as reviewed by adinn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5083