RFR: 8259948: Aarch64: Add cast nodes for Aarch64 Neon backend [v2]

Wu Yan wuyan at openjdk.java.net
Thu Aug 12 09:36:32 UTC 2021


On Tue, 10 Aug 2021 09:12:36 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix code style
>
> test/hotspot/gtest/aarch64/aarch64-asmtest.py line 1541:
> 
>> 1539:                         ["fcvtzv", "__ fcvtzv(v0, __ T4S, v1);",                         "fcvtzs\tv0.4s, v1.4s"],
>> 1540:                         # SVE instructions
>> 1541:                         ["cpy",    "__ sve_cpy(z0, __ S, p0, v1);",                      "mov\tz0.s, p0/m, s1"],
> 
> Please use the `CPY` AArch64 instruction here, rather than `MOV`.

Thanks, I'll fix it.

> test/hotspot/gtest/aarch64/asmtest.out.h line 715:
> 
>> 713:     __ stxpw(r6, zr, zr, sp);                          //       stxp    w6, wzr, wzr, [sp]
>> 714:     __ dup(v0, __ T16B, zr);                           //       dup     v0.16b, wzr
>> 715:     __ dups(v0, __ T2S, v1);                           //       mov     s0, v1.s[0]
> 
> Please use the `DUP` AArch64 instruction here, rather than `MOV`.

OK.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4839


More information about the hotspot-compiler-dev mailing list