RFR: 8272315: Improve assert_different_registers [v3]
Kim Barrett
kbarrett at openjdk.java.net
Thu Aug 12 14:33:53 UTC 2021
> Please review this improvement to assert_different_register.
>
> It reduces ~250 lines of repetitive code to ~10 lines, and improves the
> error message on failure by printing a duplicated registers name.
>
> Unfortunately, this isn't enough to eliminate AbstractRegister[Impl].
> Although it seems to no longer be needed for the Oracle-supported platforms,
> the linux-arm/ppc64le/s390 platforms all use the value() function provided
> by AbstractRegisterImpl.
>
> Testing:
> tier1 on Oracle supported platforms.
> built linux-arm/ppc64le/s390.
>
> Locally changed a call to have a duplicate register and verified the error
> message had a useful register name.
Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Merge branch 'master' into reg_enum
- nested loop instead of sort
- simplify assert_different_registers
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5083/files
- new: https://git.openjdk.java.net/jdk/pull/5083/files/839a5bb8..2f8f7732
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5083&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5083&range=01-02
Stats: 2702 lines in 190 files changed: 1846 ins; 459 del; 397 mod
Patch: https://git.openjdk.java.net/jdk/pull/5083.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5083/head:pull/5083
PR: https://git.openjdk.java.net/jdk/pull/5083
More information about the hotspot-compiler-dev
mailing list