RFR: 8271883: Math CopySign optimization for x86 [v2]

Marcus G K Williams mgkwill at openjdk.java.net
Fri Aug 13 15:09:26 UTC 2021


On Fri, 13 Aug 2021 04:15:46 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> src/hotspot/cpu/x86/x86.ad line 5823:
>> 
>>> 5821: %}
>>> 5822: 
>>> 5823: instruct copySignD_reg(regD dst, regD src, regD tmp1, rRegL tmp2, regD zero) %{
>> 
>> Graph shape created for this will always pass zero operand as an immediate argument. Do you see any issue if you just keep one pattern (copySignD_imm) ?
>
> @mgkwill , haven't seen your response on this.

@jatin-bhateja, @sviswa7 told me that you and her discussed it and decided that removing copySignD_reg was appropriate as it is not needed. I've removed copySignD_reg.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5005


More information about the hotspot-compiler-dev mailing list