Integrated: 8271883: Math CopySign optimization for x86

[Marcus G K Williams]

On Wed, 4 Aug 2021 20:12:41 GMT, Marcus G K Williams <mgkwill at openjdk.org> wrote:

> Intrinsic for Math.copySign is disabled on x86_64.
> 
> We can improve on generated c2 instructions for float and double, and this change adds optimized intrinsics for float and double Math.copySign.
> 
> ### **Math.copySign(double)**
> _From:_
>   0x00007f7d606e5dac:   vmovq  %xmm1,%r10
>   0x00007f7d606e5db1:   vmovq  %xmm0,%r11
>   0x00007f7d606e5db6:   movabs $0x7fffffffffffffff,%r8
>   0x00007f7d606e5dc0:   and    %r8,%r11
>   0x00007f7d606e5dc3:   movabs $0x8000000000000000,%r8
>   0x00007f7d606e5dcd:   and    %r8,%r10
>   0x00007f7d606e5dd0:   or     %r11,%r10
>   0x00007f7d606e5dd3:   vmovq  %r10,%xmm0                   
> 
> _To:_
>   0x00007fc3c14c63ac:   movabs $0x7fffffffffffffff,%r10
>   0x00007fc3c14c63b6:   vmovq  %r10,%xmm2
>   0x00007fc3c14c63bb:   vpternlogq $0xe4,%xmm2,%xmm1,%xmm0
> 
> ### **Math.copySign(float)**
> _From:_
>   0x00007ff8886e60ac:   vmovd  %xmm1,%r11d
>   0x00007ff8886e60b1:   vmovd  %xmm0,%r10d
>   0x00007ff8886e60b6:   and    $0x80000000,%r11d
>   0x00007ff8886e60bd:   and    $0x7fffffff,%r10d
>   0x00007ff8886e60c4:   or     %r10d,%r11d
>   0x00007ff8886e60c7:   vmovd  %r11d,%xmm0
> _To:_
>   0x00007fc7d94c63ac:   mov    $0x7fffffff,%r10d
>   0x00007fc7d94c63b2:   vmovd  %r10d,%xmm3
>   0x00007fc7d94c63b7:   vpternlogd $0xe4,%xmm3,%xmm1,%xmm0
> 
> #### _**Performance of patch using updated test/micro/org/openjdk/bench/vm/compiler/Signum.java:**_
> #### **BEFORE**
> Signum._5_copySignFloatTest       avgt    5  2.442 ? 0.024  ns/op
> Signum._7_copySignDoubleTest      avgt    5  2.400 ? 0.033  ns/op
> 
> #### **PATCH**
> Signum._5_copySignFloatTest       avgt    5  2.029 ? 0.011  ns/op
> Signum._7_copySignDoubleTest      avgt    5  2.029 ? 0.024  ns/op
> 
> #### **JTREG that covers this case:**
> test/hotspot/jtreg/compiler/intrinsics/math/TestSignumIntrinsic.java
> 
> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>

This pull request has now been integrated.

Changeset: 87d2761f
Author:    Marcus G K Williams <mgkwill at openjdk.org>
Committer: Sandhya Viswanathan <sviswanathan at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/87d2761f1b4572633de020b2d4681918c6f10f06
Stats:     111 lines in 3 files changed: 110 ins; 0 del; 1 mod

8271883: Math CopySign optimization for x86

Reviewed-by: jbhateja, sviswanathan, kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/5005