RFR: 8272573: Redundant unique_concrete_method_4 dependencies

Vladimir Ivanov vlivanov at openjdk.java.net
Tue Aug 17 18:40:38 UTC 2021


Equivalence checks in `Dependencies::assert_common_4()` are too strong which leads to `unique_concrete_method_4` dependencies being repeatedly recorded and duplicating nmethod dependencies registered.

The underlying problem is `note_dep_seen()` mutates internal bitmap, but the nested checks fail fast.
So, multiple requests are required to populate the bit-map for all the arguments in order to make the detection of duplicate assertions work. And it leads to duplicate dependencies registered.

It turns out `call_site_target_value` is also affected in a similar manner (see `Dependencies::assert_common_2` for dependencies without explicit context argument), so I fix it along the way.

Testing: hs-tier1 - hs-tier6

-------------

Commit messages:
 - Handle all note_dep_seen cases
 - 8272573: Redundant unique_concrete_method_4 dependencies

Changes: https://git.openjdk.java.net/jdk/pull/5141/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5141&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8272573
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5141.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5141/head:pull/5141

PR: https://git.openjdk.java.net/jdk/pull/5141


More information about the hotspot-compiler-dev mailing list