RFR: 8272573: Redundant unique_concrete_method_4 dependencies [v2]

[Vladimir Kozlov]

On Tue, 17 Aug 2021 21:34:47 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Equivalence checks in `Dependencies::assert_common_4()` are too strong which leads to `unique_concrete_method_4` dependencies being repeatedly recorded and duplicating nmethod dependencies registered.
>> 
>> The underlying problem is `note_dep_seen()` mutates internal bitmap, but the nested checks fail fast.
>> So, multiple requests are required to populate the bit-map for all the arguments in order to make the detection of duplicate assertions work. And it leads to duplicate dependencies registered.
>> 
>> It turns out `call_site_target_value` is also affected in a similar manner (see `Dependencies::assert_common_2` for dependencies without explicit context argument), so I fix it along the way.
>> 
>> Testing: hs-tier1 - hs-tier6
>
> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Check all arguments

Perfect! Thank you for explanation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5141