Integrated: 8272573: Redundant unique_concrete_method_4 dependencies

[Vladimir Ivanov]

On Tue, 17 Aug 2021 11:45:49 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

> Equivalence checks in `Dependencies::assert_common_4()` are too strong which leads to `unique_concrete_method_4` dependencies being repeatedly recorded and duplicating nmethod dependencies registered.
> 
> The underlying problem is `note_dep_seen()` mutates internal bitmap, but the nested checks fail fast.
> So, multiple requests are required to populate the bit-map for all the arguments in order to make the detection of duplicate assertions work. And it leads to duplicate dependencies registered.
> 
> It turns out `call_site_target_value` is also affected in a similar manner (see `Dependencies::assert_common_2` for dependencies without explicit context argument), so I fix it along the way.
> 
> Testing: hs-tier1 - hs-tier6

This pull request has now been integrated.

Changeset: 96107e31
Author:    Vladimir Ivanov <vlivanov at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/96107e31dfe115fc102fa54d7bdd523c8a79ff76
Stats:     10 lines in 1 file changed: 7 ins; 0 del; 3 mod

8272573: Redundant unique_concrete_method_4 dependencies

Reviewed-by: kvn, thartmann

-------------

PR: https://git.openjdk.java.net/jdk/pull/5141