RFR: 8267265: Use new IR Test Framework to create tests for C2 IGV transformations

[John Tortugo]

On Tue, 17 Aug 2021 16:59:45 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> I am **against** moving tests under `/c2` directory. This directory was created to split original set of tests to run in parallel and not related to C2 compiler. I want to have directories in `/compiler` per optimization/transformation type as we have now. For example, `/loopopts` is for C2 only but it is not under `/c2`.
>> 
>> Actually I want to clear `c2` and `c1` directories eventually to move tests to corresponding category directories instead.
>> 
>> So I am for `/compiler/irTests`.
>
>> This directory was created to split original set of tests to run in parallel and not related to C2 compiler
> 
> aren't you mixing this up w/ `tier1_compiler_[1-3]` test group? if you aren't, this was the wrong way to split tests and we need to fix that.
> 
>>  I want to have directories in `/compiler` per `optimization/transformation` type as we have now. For example, `/loopopts` is for C2 only but it is not under `/c2`.
>> Actually I want to clear `c2` and `c1` directories eventually to move tests to corresponding category directories instead.
> 
> I would prefer to clear `/compiler` directory and move c1-specific tests into `/compiler/c1` directory and c2-specific tests into `/compiler/c2` with optimization/transformation type being subdirectories inside `/compiler/c[12]` (and shared/common tests moved to `/compiler/shared`), so `loopopts` tests are to moved to `/compiler/c2/loopopts`. one of the reasons, most of optimizations tests will be compiler-specific and having them together in `/compiler` doesn't make much sense and just makes it harder to navigate/use test base. e.g. if we have all c2 tests in `/compiler/c2`, one can easily run them together to test c2 changes, if c2-specific tests are in several directories in `/compiler`, so one will have to have intrinsic knowledge about all tests in `/compiler` to select the right one.

Should I move all  tests created in this PR to folders under `/compiler/c2/`? Separated by type of optimization - loopOpts, scalarReplacement, etc?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5135