RFR: 8272873: C2: Inlining should not depend on absolute call site counts

Vladimir Kozlov kvn at openjdk.java.net
Tue Aug 24 17:14:28 UTC 2021


On Tue, 24 Aug 2021 17:04:08 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

>> src/hotspot/share/runtime/globals.hpp line 1407:
>> 
>>> 1405:           range(0, max_jint)                                                \
>>> 1406:                                                                             \
>>> 1407:   product_pd(intx, InlineFrequencyCount, DIAGNOSTIC,                        \
>> 
>> You need to file CSR to remove product flag.
>
> It's a diagnostic flag, so it doesn't need a CSR.

Right, I missed that.

>> test/lib-test/jdk/test/whitebox/vm_flags/IntxTest.java line 39:
>> 
>>> 37: public class IntxTest {
>>> 38:     private static final String FLAG_NAME = "OnStackReplacePercentage";
>>> 39:     private static final String FLAG_DEBUG_NAME = "BciProfileWidth";
>> 
>> Why this addition for `BciProfileWidth`?
>
> This test requires any diagnostic intx flag. I just found the first available.

Got it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5238


More information about the hotspot-compiler-dev mailing list