RFR: 8272873: C2: Inlining should not depend on absolute call site counts

[Igor Veresov]

On Tue, 24 Aug 2021 15:44:41 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

> C2 considers absolute call site counts in its inlining decisions, which seems very wrong considering the asynchronous nature of profiling and background compilation (See InlineTree::should_inline()). It causes substantial over-inlining, which in presence of a depth-first inlining can lead to an early cut off. It also is inherently unstable. C2 already uses call frequency as an additional factor and it's better to consider only that in the inlining heuristic. I did extensive benchmarking it yielded almost no losses and single-digit wins (up to 5%) on some benchmarks. I think it's safe to remove/deprecate InlineFrequencyCount and continue using InlineFrequencyRatio instead. I found that converting the frequency computation to FP and setting InlineFrequencyRatio=0.25 (inline a method that is called a least 25% of the time) works best.

Yeah, `UseCounterDecay` does nothing and needs to be removed. Decay would actually work in an interesting way, it would cause you to inline less in general into a method that hasn't been invoked a lot. So, it would, in essence, reduce the quality of methods that are mildly hot, saving possibly on compilation resources. It's an interesting effect, but I doubt that it was the intention behind `InlineFrequencyCount`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5238