RFR: 8267265: Use new IR Test Framework to create tests for C2 IGV transformations [v3]

John Tortugo github.com+2249648+johntortugo at openjdk.java.net
Tue Aug 31 21:14:24 UTC 2021


> Hi, can I please get some reviews for this Pull Request? Here is a summary of the changes:
> 
> - Add tests, using the new IR-based test framework, for several of the Ideal transformations on Add, Sub, Mul, Div, Loop nodes and some simple Scalar Replacement transformations.
> - Add more default IR regex's to IR-based test framework.
> - Changes to Sub, Div and Add Ideal nodes to that transformations on Int and Long types are the whenever possible same.
> - Changes to Sub*Node, Div*Node and Add*Node Ideal methods to fix some bugs and include new transformations.
> - New JTREG "ir_transformations" test group under test/hotspot/jtreg.

John Tortugo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'openjdk:master' into jdk-8267265
 - Reverting changes to Ideal transformations. Removing failing tests. Reverting order of nodes in IRNode.
 - Fix carriage returns one more time.
 - Fix more carriage returns.
 - Fixing carriage return chars.
 - Adding some tests for Ideal transformations.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5135/files
  - new: https://git.openjdk.java.net/jdk/pull/5135/files/22565304..ac430bf7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5135&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5135&range=01-02

  Stats: 13949 lines in 544 files changed: 7990 ins; 3191 del; 2768 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5135.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5135/head:pull/5135

PR: https://git.openjdk.java.net/jdk/pull/5135


More information about the hotspot-compiler-dev mailing list