RFR: 8262341: Refine identical code in AddI/LNode.

Eric Liu eliu at openjdk.java.net
Mon Dec 6 09:09:20 UTC 2021


On Mon, 6 Dec 2021 08:45:02 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/addnode.cpp line 280:
>> 
>>> 278:   }
>>> 279:   if (op1 == Op_Sub(bt)) {
>>> 280:     const Type *t_sub1 = phase->type(in1->in(1));
>> 
>> I'm not very clear about the current code style which we should follow. Shall we need to align the style in the changed code?
>
> Are you commenting about the change from:
> if( op1 to if (op1
> ?
> The first style is used in a some places and the guideline is to switch to the second one.

How about the style like `const Type *t_sub1`? Whether it should be `const Type* t_sub1`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6607


More information about the hotspot-compiler-dev mailing list