RFR: 8262341: Refine identical code in AddI/LNode. [v2]

Roland Westrelin roland at openjdk.java.net
Tue Dec 7 10:37:04 UTC 2021


On Tue, 7 Dec 2021 01:47:23 GMT, Fei Gao <fgao at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - T *p to -> T* p
>>  - Merge branch 'master' into JDK-8262341
>>  - fix
>
> src/hotspot/share/opto/addnode.hpp line 54:
> 
>> 52:   // We also canonicalize the Node, moving constants to the right input,
>> 53:   // and flatten expressions (so that 1+x+2 becomes x+3).
>> 54:   virtual Node* Ideal(PhaseGVN *phase, bool can_reshape);
> 
> Should be `PhaseGVN* phase` here?

Thanks for looking at this. You're right. Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6607


More information about the hotspot-compiler-dev mailing list