RFR: 8276901: Implement UseHeavyMonitors consistently [v11]

[David Holmes]

(re-sending for the mailing lists as previous mail seems lost)

On 8/12/2021 12:40 am, Roman Kennke wrote:
> On Tue, 7 Dec 2021 14:34:48 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
> 
>> So Tier[1-4] are complete and look fine. Mach5 is a bit over loaded at the moment so Tier[5-8] are still running. I think the Tier[1-4] results and the partial Tier[5-8] are good enough to say that these bits are okay.
> 
> Thanks, David! I will then go ahead and integrate this PR.

That was Daniel not David.

Sorry I didn't get back to this sooner but ...

I am not happy with the argument processing in 
Arguments::check_vm_args_consistency. This method does not call fatal(), 
it reports a warning or error message and returns false if VM 
initialization should not continue. Also for platforms where 
UseHeavyMonitors is not fully implemented it should not just be a 
warning IMO but also cause initialization to not continue. If we are 
going to return false then the error message should go to the error 
stream not be issued as a warning(). Please file a fillow up issue and 
fix this.

I remain concerned about the impact of this change on platforms that 
don't support UseHeavyMonitors fully.

David

> Cheers,
> Roman
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/6320