RFR: 8259610: VectorReshapeTests are not effective due to failing to intrinsify "VectorSupport.convert" [v4]

[Mai Đặng Quân Anh]

On Thu, 9 Dec 2021 16:59:18 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Mai Đặng Quân Anh has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix cpu pattern on Neon
>
> test/hotspot/jtreg/compiler/vectorapi/reshape/TestVectorCastAVX1.java line 50:
> 
>> 48:         String testMethods = String.join(",", TestCastMethods.AVX1_CAST_TESTS.stream()
>> 49:                 .map(VectorSpeciesPair::format)
>> 50:                 .toList());
> 
> Use a joining collector:
> Suggestion:
> 
>         String testMethods = TestCastMethods.AVX1_CAST_TESTS.stream()
>                 .map(VectorSpeciesPair::format)
>                 .collect(joining(","));
> 
> 
> There is also a fair bit of repetition in each Test class, consider an abstract class with static method accepting the test class, additional flags, and test cases list? That would be more applicable if three general cases in `TestVectorReinterpret` were separated out, or at least the expand tests from the rebracket tests.

Done, I created a helper method in `VectorReshapeHelper` and pass the necessary information to it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6724