RFR: 8278584: compiler/vectorapi/VectorMaskLoadStoreTest.java failed with "Error: ShouldNotReachHere()" [v5]

[Jie Fu]

On Mon, 13 Dec 2021 23:36:49 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all,
>> 
>> I'd like to fix the vector_length_encoding error in `long_to_maskLE8_avx` and `long_to_maskGT8_avx`.
>> Since the input parameter of `vector_length_encoding` [1] is the number of vector bytes (not number of vector bits), I believe we shouldn't `mask_len*8` [2][3].
>> 
>> The patch also removes an useless statement [4].
>> 
>> Testing:
>>    - vector api tests on Linux/x64-{AVX512, AVX2}
>> 
>> Thanks.
>> Best regards,
>> Jie
>> 
>> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86.ad#L1219
>> [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86.ad#L9552
>> [3] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86.ad#L9568
>> [4] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86.ad#L9580
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment for -XX:DisableIntrinsic=_VectorMaskOp

Thank you all for the review and comment.

@jatin-bhateja , are you OK with the fix?
Will push it tomorrow if there is no objection.
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6808