RFR: 8278471: Reorder optimizations in addnode Ideal [v2]

Zhiqiang Zang duke at openjdk.java.net
Tue Dec 14 03:04:13 UTC 2021


On Mon, 13 Dec 2021 10:53:27 GMT, Mai Đặng Quân Anh <duke at openjdk.java.net> wrote:

> Hi, I think just deleting those 2 should be okay.
> 
> Regarding idealisation, if you look into `PhaseGVN::transform`, it is clear that `Node::Ideal` is called repeatedly until there is nothing change anymore. Then `Node::Value` is called to do constant propagation before `Node::Identity` is called to get rid of redundant operations. Finally, value numbering is the transformation which deduplicates all equivalent `Node`s into a single one.
> 
> https://github.com/openjdk/jdk/blob/ccdb9f1b160a0f49ee86c7a2714d2381d68419cc/src/hotspot/share/opto/phaseX.cpp#L828

Thank you so much for answering both my questions!

-------------

PR: https://git.openjdk.java.net/jdk/pull/6752


More information about the hotspot-compiler-dev mailing list