RFR: 8278471: Reorder optimizations in addnode Ideal [v3]

Zhiqiang Zang duke at openjdk.java.net
Tue Dec 14 15:48:07 UTC 2021


On Mon, 13 Dec 2021 18:24:42 GMT, Zhiqiang Zang <duke at openjdk.java.net> wrote:

>> Reorder optimizations in addnode so special cases appear before general cases; otherwise the special cases would be never covered.
>> 
>> `(a - b) + (c - d)` subsumes both `(a - b) + (b - c)` and `(a - b) + (c - a)`. Therefore `(a - b) + (b - c)` and `(a - b) + (c - a)` have to be placed before `(a - b) + (c - d)` so that they can work.
>
> Zhiqiang Zang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove unnecessary optimizations.

> 

Thank you for your review. @DamonFool Would you mind making the change to JBS for me? I don't have an account there, so I am not able to edit. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6752


More information about the hotspot-compiler-dev mailing list