[jdk18] RFR: 8274323: compiler/codegen/aes/TestAESMain.java failed with "Error: invalid offset: -1434443640" after 8273297
Vladimir Kozlov
kvn at openjdk.java.net
Wed Dec 15 23:08:10 UTC 2021
On Tue, 14 Dec 2021 20:05:59 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> The failure happens with XX:+DeoptimizeAlot option. I've set reexecute bit and reset the appropriate state for the interpreter to execute the code when deoptimization occurs.
>
> Yes, we need to reexecute because code could be deoptimized during `new_array()` allocation.
> But why we allocate this temp array in Java heap? Why not on stack in stub code?
>
> Also I noticed next return from intrinsics code could be moved up before we generate new nodes in graph: `if (Matcher::htbl_entries == -1) return false;`
> @vnkozlov Allocating the array in the stub will cause few changes on x86-64 side as well as change in aarch64 stubGenerator code as subkeyHtbl_48_entries will no longer be passed as an argument.
> Do let me know if you think it is okay to proceed with these changes. Thank you.
@smita-kamath Thank you for looking on it. Okay, let proceed with your current fix for JDK 18. File RFE for JDK 19 to rework the code.
Meanwhile I will test this fix.
-------------
PR: https://git.openjdk.java.net/jdk18/pull/19
More information about the hotspot-compiler-dev
mailing list