RFR: 8274982: Add a test for 8269574. [v2]

Evgeny Nikitin enikitin at openjdk.java.net
Thu Dec 16 20:20:49 UTC 2021


On Thu, 11 Nov 2021 05:56:37 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Evgeny Nikitin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Get rid of while-breaks
>>  - Add JIT requirements
>>  - Remove explicit type specifiers for own class static calls
>>  - Remove redundant build directive
>>  - Merge branch 'master' into JDK-8274982/public
>>  - 8274982: Add a test for 8269574.
>
> test/hotspot/jtreg/compiler/jvmti/TriggerBuiltinExceptionsTest.java line 28:
> 
>> 26:  * @bug 8269574
>> 27:  * @summary Verifies that exceptions are reported correctly to JVMTI in the compiled code
>> 28:  * @requires vm.jvmti
> 
> You also require the JIT

Added a requirement for the c1 or c2.

> test/hotspot/jtreg/compiler/jvmti/TriggerBuiltinExceptionsTest.java line 32:
> 
>> 30:  *
>> 31:  * @build sun.hotspot.WhiteBox
>> 32:  * @build compiler.jvmti.TriggerBuiltinExceptionsTest
> 
> Explicit build directive should not be needed.

Fixed, thanks

> test/hotspot/jtreg/compiler/jvmti/TriggerBuiltinExceptionsTest.java line 59:
> 
>> 57: public class TriggerBuiltinExceptionsTest {
>> 58:     private static final WhiteBox WB = WhiteBox.getWhiteBox();
>> 59:     private static final int ITERATIONS = 30;           //Arbitrary value, feel free to change
> 
> Style nit: space after //

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5889


More information about the hotspot-compiler-dev mailing list