RFR: JDK-8258603 c1 IR::verify is expensive [v3]

[Ludvig Janiuk]

On Fri, 17 Dec 2021 08:35:47 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanup2
>
> src/hotspot/share/c1/c1_IR.cpp line 1401:
> 
>> 1399: 
>> 1400:     for (int i = 0; i < block->end()->number_of_sux(); i++) {
>> 1401:       if (blocks.contains(block->end()->sux_at(i))) { continue; }
> 
> I think it's better to move the `continue` to a new line.

I went ahead and flipped the ifs instead

> src/hotspot/share/c1/c1_Optimizer.cpp line 441:
> 
>> 439: 
>> 440: #ifndef PRODUCT
>> 441:     _hir->verify_local(blocks_to_verify_later);
> 
> You can also use `NOT_PRODUCT()` here.

Went with DEBUG_ONLY

-------------

PR: https://git.openjdk.java.net/jdk/pull/6850