[jdk18] RFR: 8274323: compiler/codegen/aes/TestAESMain.java failed with "Error: invalid offset: -1434443640" after 8273297 [v2]

Vladimir Kozlov kvn at openjdk.java.net
Fri Dec 17 19:30:32 UTC 2021


On Fri, 17 Dec 2021 18:10:00 GMT, Smita Kamath <svkamath at openjdk.org> wrote:

>> The failure happens with XX:+DeoptimizeAlot option. I've set reexecute bit and reset the appropriate state for the interpreter to execute the code when deoptimization occurs.
>
> Smita Kamath has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix to allocate 48 additonal htbl entries in the stub.

I have few comments. I will start testing.

src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4444:

> 4442:     __ movptr(state, state_mem);
> 4443: #endif
> 4444:     __ subptr(rsp, 96 * longSize); // Create space on the stack for htbl entries

Is this aligned correctly? Or alignment does not matter?

src/hotspot/share/opto/library_call.cpp line 6766:

> 6764:   Node* ghash_object = argument(8);
> 6765: 
> 6766:     // (1) in, ct and out are arrays.

You need to restore indent.

-------------

PR: https://git.openjdk.java.net/jdk18/pull/19


More information about the hotspot-compiler-dev mailing list