RFR: JDK-8258603 c1 IR::verify is expensive [v5]

[Ludvig Janiuk]

On Fri, 17 Dec 2021 19:50:05 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   flip ifs
>
> So the whole block of code in `c1_IR.cpp` is under `#ifndef PRODUCT`.
> But is it used in **optimized** build or only in debug?
> 
> I suggest to change `#ifndef PRODUCT` at line 1224 to `#ifdef ASSERT` and try to build optimized VM to see if it is used in it.
> I see only prints and asserts.

@vnkozlov I don't know what an optimized build is, you'll have to point me to some instructions if you want me to build one. 

I think changing assertions around BlockPrinter is outside the scope of this PR. Perhaps another PR to clean up optimized builds is in order for the future?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6850