RFR: 8277893: Arraycopy stress tests [v5]

Aleksey Shipilev shade at openjdk.java.net
Mon Dec 20 11:59:05 UTC 2021


> I would like to fork the new tests off the JDK-8150730. These tests were instrumental in capturing many bugs in my arraycopy work, and I think they are good on their own merit, because they provide a test for the current baseline and on-going minor improvements in arraycopy on all platforms, not only x86_64, and they might be cleanly backportable.
> 
> A brief tour of these tests:
> 
> - Tests all data types;
> - Tests small arrays exhaustively, which captures conjoint/disjoint cases, errors near the edges, etc;
> - Tests large arrays with fuzzing around powers of two and powers of ten, both conjoint and disjoint cases;
> - Tests all available compilation modes for arraycopy stubs; for example, running on AVX-512 enabled machine runs all versions down to `-XX:UseAVX=0 -XX:UseSSE=0` cases;
> - Tests with/without compressed oops mode -- theoretically only needed for `Object` copies, but Hotspot cobbles together int+coops and long+no-coops loops, so I decided to alternate coops mode for all data types;
> 
> My previous version used individual `@run` clauses for all configurations, but I think the Java driver is cleaner and easier to maintain.
> 
> Test times:
> 
> 
> # x86_64 (TR 3970X)
> real	4m6.192s
> user	52m50.523s
> sys	0m13.755s
> 
> # x86_64 (TR 3970X) -XX:+UseZGC
> real	6m2.573s
> user	72m43.541s
> sys	0m25.697s
> 
> # x86_32 (TR 3970X)
> real	6m56.405s
> user	92m56.377s
> sys	0m6.677s
> 
> # x86_64 (i5-11500)
> real	29m19.024s
> user	103m52.925s
> sys	1m7.175s
> 
> # AArch64 (ThunderX2)
> real	2m59.623s
> user	26m14.624s
> sys	0m9.771s
> 
> 
> Since these tests are quite long, especially on small machines, I hooked them up to `hotspot:tier3`.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `compiler/stress/arraycopy`
>  - [x] Linux x86_32 fastdebug `compiler/stress/arraycopy`
>  - [x] Linux AArch64 fastdebug `compiler/stress/arraycopy`

Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:

 - Merge branch 'master' into JDK-8277893-arraycopy-tests
 - Bump timeout to 7200
 - Merge branch 'master' into JDK-8277893-arraycopy-tests
 - Package declarations
 - Add safety check for small systems
 - Renames
 - Single driver for all the tests
 - Safer timeout settings
 - Post-merge TEST.groups cleanup
 - Merge branch 'master' into JDK-8277893-arraycopy-tests
 - ... and 4 more: https://git.openjdk.java.net/jdk/compare/07d279a8...6789eb8b

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/6594/files
  - new: https://git.openjdk.java.net/jdk/pull/6594/files/b749c367..6789eb8b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6594&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6594&range=03-04

  Stats: 20094 lines in 535 files changed: 14663 ins; 3580 del; 1851 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6594.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6594/head:pull/6594

PR: https://git.openjdk.java.net/jdk/pull/6594


More information about the hotspot-compiler-dev mailing list