[jdk18] RFR: 8278889: AArch64: [vectorapi] VectorMaskLoadStoreTest.testMaskCast() test fail [v2]

Eric Liu eliu at openjdk.java.net
Tue Dec 21 13:15:04 UTC 2021


On Tue, 21 Dec 2021 06:54:50 GMT, Ningsheng Jian <njian at openjdk.org> wrote:

>> Eric Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   small fix
>>   
>>   Change-Id: Id71ebe5161fac08a689ee3ec538b485f6c172186
>
> src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 line 389:
> 
>> 387:     Assembler::SIMD_RegVariant size = __ elemType_to_regVariant(bt);
>> 388:     __ sve_dup(as_FloatRegister($tmp$$reg), size, as_Register($src$$reg));
>> 389:     __ sve_ptrue_lanecnt(as_PRegister($dst$$reg), size, Matcher::vector_length(this));
> 
> I think you can generate this insn conditionally, only when current vector size is not MaxVectorSize.

Fixed. Thanks for your review.

-------------

PR: https://git.openjdk.java.net/jdk18/pull/49


More information about the hotspot-compiler-dev mailing list