[jdk18] RFR: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0

Sandhya Viswanathan sviswanathan at openjdk.java.net
Tue Dec 21 22:28:17 UTC 2021


On Tue, 21 Dec 2021 19:32:18 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> See the reproducer and the analysis in the bug. 
> 
> The fix is simple: `Matcher::match_rule_supported` should handle the predicates for current `SqrtF` and `SqrtD` match rules.
> 
> Additional testing:
>  - [x] Linux x86_32 `-XX:UseAVX=0 -XX:UseSSE=0`, new test now passes
>  - [x] Linux x86_32 `-XX:UseAVX=0 -XX:UseSSE=1`, new test passes
>  - [x] Linux x86_32 `-XX:UseAVX=0 -XX:UseSSE=2`, new test passes
>  - [x] Linux x86_32 `-XX:UseAVX=0 -XX:UseSSE=0`, `jdk/incubator/vector/` now passes
>  - [x] Linux x86_32 `-XX:UseAVX=0 -XX:UseSSE=1`, `jdk/incubator/vector/` passes
>  - [x] Linux x86_32 `-XX:UseAVX=0 -XX:UseSSE=2`, `jdk/incubator/vector/` passes (some unrelated failures)
>  - [x] Linux x86_64, new test passes

Looks good to me.

-------------

Marked as reviewed by sviswanathan (Reviewer).

PR: https://git.openjdk.java.net/jdk18/pull/60


More information about the hotspot-compiler-dev mailing list