RFR: 8260581: IGV: enhance node search [v4]

[Xin Liu]

On Mon, 1 Feb 2021 11:34:59 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Apply several enhancements to the quick node search functionality: 
>> 
>> - Allow users to search by node id or name by default (i.e. when no property is specified) instead of name only.
>> - Show partial matches when searching for a specific property (e.g. so that searching "type=con" lists all "control"-type nodes).
>> - Avoid showing the "All _N_ matching nodes" entry if there is a single match, or the user is searching a numeric value.
>> - Rank matches so that full matches are listed first, followed by matches at the beginning of the partially matched value, followed by the rest of matches in increasing size of the partially matched value. Numeric matches with the same rank are sorted increasingly. For example, searching "5" on a set of nodes with labels {"5 AddI", "25 AddL", "253 AddL", "554 MulI"} should list the matches as follows:
>>     1. **5** AddI
>>     2. **5**54 MulI
>>     3. 2**5** AddL
>>     4. 2**5**3 AddL
>> 
>> As an illustration of some of these enhancements, this screenshot shows the behavior of the quick node search functionality before the changes:
>> 
>> ![search-before](https://user-images.githubusercontent.com/8792647/106283438-374ba500-6242-11eb-8ef4-d18117eabcbb.png)
>> 
>> and after:
>> 
>> ![search-after](https://user-images.githubusercontent.com/8792647/106282880-7e856600-6241-11eb-8cb5-48fae5582cc2.png)
>> 
>> 
>> Tested manually on small and large (~10000 nodes) graphs. Thanks to Christian Hagedorn for feedback on several iterations of the enhancements.
>> 
>> As part of the review, please evaluate not just the code changes but also the usability.
>
> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Sort same-rank matches by first-word numeric value
>   
>   Sort otherwise equally relevant matches by node id, which is by default the
>   first word in node labels. Thanks to Christian Hagedorn for the suggestion and
>   (slightly adapted) patch.

LGTM. I ran it with your patch. it works as expected.

-------------

Marked as reviewed by xliu (no project role).

PR: https://git.openjdk.java.net/jdk/pull/2285