RFR: 8260928: InitArrayShortSize constraint func should print a helpful error message
Aleksey Shipilev
shade at openjdk.java.net
Tue Feb 2 11:53:45 UTC 2021
On Tue, 2 Feb 2021 11:31:34 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
> The `InitArrayShortSize` flag requires a value that is a multiple of `BytesPerLong` but no corresponding error message is printed:
> java -XX:InitArrayShortSize=7
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
>
> Thanks,
> Tobias
Looks fine to me.
Marked as reviewed by shade (Reviewer).
src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp line 307:
> 305: JVMFlag::printError(verbose,
> 306: "InitArrayShortSize (" INTX_FORMAT ") must be "
> 307: "a multiple of %d\n", value, BytesPerLong);
Consider indenting them a bit. I think the line starting from `"a...` has one excess whitespace.
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2351
More information about the hotspot-compiler-dev
mailing list