RFR: 8258799 : [Testbug] RandomCommandsTest must check if tested directive is added via jcmd

Nils Eliasson neliasso at openjdk.java.net
Wed Feb 3 08:06:54 UTC 2021


On Tue, 2 Feb 2021 22:58:19 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> RandomCommandsTest.java is checking a mix of valid and invalid compilecommands and compiler directives. When they fail they have different behaviour:
>> 
>> A compilecommand that is malformed will result in a printed error, and then the VM continues. 
>> A compiler directive that is malformed, that is added via commandline, will abort the VM, much like any other VM-flag would. 
>> A compiler directive that is malformed, that is added via jcmd will print an error, and the VM continues - just like with any other jcmd.
>> 
>> The RandomCommandsTest fails when generating a malformed compiler directive and adding it via jcmd - because it expects the VM to abort.
>> 
>> This patch fixes that.
>
> Marked as reviewed by iignatyev (Reviewer).

Thank you Igor and Vladimir!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2364


More information about the hotspot-compiler-dev mailing list