Integrated: 8260581: IGV: enhance node search

Roberto Castañeda Lozano rcastanedalo at openjdk.java.net
Wed Feb 3 11:14:50 UTC 2021


On Thu, 28 Jan 2021 11:07:38 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> Apply several enhancements to the quick node search functionality: 
> 
> - Allow users to search by node id or name by default (i.e. when no property is specified) instead of name only.
> - Show partial matches when searching for a specific property (e.g. so that searching "type=con" lists all "control"-type nodes).
> - Avoid showing the "All _N_ matching nodes" entry if there is a single match, or the user is searching a numeric value.
> - Rank matches so that full matches are listed first, followed by matches at the beginning of the partially matched value, followed by the rest of matches in increasing size of the partially matched value. Numeric matches with the same rank are sorted increasingly. For example, searching "5" on a set of nodes with labels {"5 AddI", "25 AddL", "253 AddL", "554 MulI"} should list the matches as follows:
>     1. **5** AddI
>     2. **5**54 MulI
>     3. 2**5** AddL
>     4. 2**5**3 AddL
> 
> As an illustration of some of these enhancements, this screenshot shows the behavior of the quick node search functionality before the changes:
> 
> ![search-before](https://user-images.githubusercontent.com/8792647/106283438-374ba500-6242-11eb-8ef4-d18117eabcbb.png)
> 
> and after:
> 
> ![search-after](https://user-images.githubusercontent.com/8792647/106282880-7e856600-6241-11eb-8cb5-48fae5582cc2.png)
> 
> 
> Tested manually on small and large (~10000 nodes) graphs. Thanks to Christian Hagedorn for feedback on several iterations of the enhancements.
> 
> As part of the review, please evaluate not just the code changes but also the usability.

This pull request has now been integrated.

Changeset: ae2c5f07
Author:    Roberto Castañeda Lozano <rcastanedalo at openjdk.org>
Committer: Vladimir Ivanov <vlivanov at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/ae2c5f07
Stats:     100 lines in 3 files changed: 76 ins; 5 del; 19 mod

8260581: IGV: enhance node search

Allow users to search by node id or name by default, show partial matches when
searching for a specific property, show 'All N matching nodes' entry only if
relevant, and rank results by level of matching.

Co-authored-by: Christian Hagedorn <chagedorn at openjdk.org>
Reviewed-by: chagedorn, vlivanov, xliu

-------------

PR: https://git.openjdk.java.net/jdk/pull/2285


More information about the hotspot-compiler-dev mailing list