RFR: 8261029: Code heap page sizes not traced correctly using os::trace_page_sizes

[Stefan Johansson]

On Wed, 10 Feb 2021 17:55:00 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> > I would prefer doing the change that records the page size i `ReservedSpace` as a separate patch and in that patch also remove all uses of `actual_reserved_page_size()`. Doing this change now is required to be able to integrate the [new test](https://github.com/openjdk/jdk/compare/master...kstefanj:test-for-trace-page-sizes) I mentioned, and I think it will be helpful for work in this area going forward.
> 
> Are you talking about [8261230](https://bugs.openjdk.java.net/browse/JDK-8261230) to do recording?
> Okay, then I am fine with this change.
> 

No that change is also just fixing places where the traced page size is incorrect. Recording the page size in `ReservedSpace` will be handled by [JDK-8261527](https://bugs.openjdk.java.net/browse/JDK-8261527) going forward.

> What testing you did for current changes?

I've done a fair amount of local JTREG testing as well as manual testing to verify we get the correct result with and without explicit large pages enabled. Are there any specific compiler tests you know of that rely on the output from this tracing?

I've also done mach5 tier 1-3 but we have few to none systems in there with explicit huge pages enabled, so that is mostly for sanity.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2481