RFR: 8261336: IGV: enhance default filters [v2]

[Christian Hagedorn]

On Mon, 15 Feb 2021 11:19:04 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> src/utils/IdealGraphVisualizer/ServerCompiler/src/com/sun/hotspot/igv/servercompiler/filters/onlyControlFlow.filter line 23:
>> 
>>> 21:   )
>>> 22: );
>>> 23: f.addRule(new RemoveFilter.RemoveRule(new MatcherSelector(new Properties.RegexpPropertyMatcher("name", "Phi|CreateEx|Cast.*|Load.|Store."))));
>> 
>> I tried the filter out on a graph and noticed that there are still some data and memory nodes shown. How about utilizing the newly added categories? I played around a bit and this seems to work quite nicely. What do you think?
>> 
>> var f = new RemoveFilter("Show only control flow");
>> f.addRule(
>>   new RemoveFilter.RemoveRule(
>>     new OrSelector(
>>       new InvertSelector(
>>         new MatcherSelector(
>>           new Properties.RegexpPropertyMatcher("category", "control|mixed|other")
>>         )
>>       ),
>>       new MatcherSelector(
>>         new Properties.StringPropertyMatcher("type", "abIO")
>>       )
>>     ), false
>>   )
>> );
>> f.addRule(new RemoveFilter.RemoveRule(new MatcherSelector(new Properties.RegexpPropertyMatcher("name", "Phi|Root|Con"))));
>> f.apply(graph);
>
> Thanks for the suggestion, I adopted it with some variations to avoid having to explicitly list pinned nodes like "Phi".

That's even better! Thanks for adopting that suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2499