RFR: 8261522: [PPC64] AES intrinsics write beyond the destination array [v2]
Lutz Schmidt
lucy at openjdk.java.net
Tue Feb 16 13:58:40 UTC 2021
On Mon, 15 Feb 2021 19:47:54 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> I'd like to replace the read-modify-write implementation from aescrypt_encryptBlock / aescrypt_decryptBlock stubs. It can cause severe problems (see bug description).
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>
> Add comment and key length assertions. Minor improvement.
Hi Martin,
the changes look good to me. Thanks for tracking that down and fixing it. I know that wasn't trivial.
One minor thing - it made me believe for a second I had missed something: in line 2631, the reference should be to vRet, not vsRet. Same is true further down in decryptBlock.
Lutz
-------------
Marked as reviewed by lucy (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2514
More information about the hotspot-compiler-dev
mailing list