RFR: 8261675: ObjectValue::set_visited(bool) sets _visited false [v2]

Vladimir Kozlov kvn at openjdk.java.net
Tue Feb 16 22:42:39 UTC 2021


On Sat, 13 Feb 2021 21:46:56 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> The setter is error-prone. it unconditionally sets _visited false.
>> this patch stores the argument to it.
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8261675: ObjectValue::set_visited(bool) sets _visited false
>   
>   use getter and setter of _visited.
>   update the year of copyright.

I am fine with your current change (getter and setter). Let push it.
And I will work on suggested optimization/clean in separate RFE (change will need comments to avoid confusion, as you have).

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2560


More information about the hotspot-compiler-dev mailing list