RFR: 8259937: guarantee(loc != NULL) failed: missing saved register with native invoker [v2]

Roland Westrelin roland at openjdk.java.net
Wed Feb 24 16:13:00 UTC 2021


On Tue, 23 Feb 2021 12:59:44 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   broken build
>
> LGTM, but I've left some suggestions in line.
> 
> Thanks for cleaning up the frame layout code. Having a fixed frame is much better than repeatedly modifying the stack pointer.
> 
> I've also done some downstream stress testing with jextract, and everything works as expected.

@JornVernee thanks for the review and the comments. The new commits should address them (cb9dd24 was pushed by accident and reverted).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2528


More information about the hotspot-compiler-dev mailing list